Acquisition/borrowing: form fields display changes

inveniosoftware / react-invenio-app-ils

Single Page App built with React for InvenioILS.

https://react-invenio-app-ils.readthedocs.io

MIT License

5 stars 19 forks source link

Acquisition/borrowing: form fields display changes #463

Closed Pineirin closed 3 years ago

Pineirin commented 3 years ago

Changes to acquisitions and borrowing forms:

Sort status values in the purchase orders form, choosing the first value as the default one.
Select Physical copy as the default value of the type in the borrowing requests form.
Refactor code for displaying the fields in the dropdown selectors, adding an order field and the possibility of using a default value. closes https://github.com/CERNDocumentServer/cds-ils/issues/327

ntarocco commented 3 years ago

@Pineirin (ping @kprzerwa FIY) the code here has a missing import, which caused the React app not building correctly, which also means that you could not functionally test such changes, the app could not run. It was reported by a user opening an issue here. Please pay attention to these things, hard to spot in a PR. I am also wondering how the tests passed, we have to check that.