inveniosoftware / react-invenio-app-ils

Single Page App built with React for InvenioILS.
https://react-invenio-app-ils.readthedocs.io
MIT License
5 stars 19 forks source link

backoffice: Add alternative titles to details page #526

Closed jrcastro2 closed 2 years ago

jrcastro2 commented 2 years ago

ALternative titles

image

Alternative abstracts

image

kpsherva commented 2 years ago

Did you verify where the alternative titles were before the latest changes erased them? In the backoffice the type of the subtitle should be also displayed

jrcastro2 commented 2 years ago

Did you verify where the alternative titles were before the latest changes erased them? In the backoffice the type of the subtitle should be also displayed

Yes they were removed in this PR apparently there was an "others" tab. I displayed the information as it is done in the frontsite. Note that the alternative_abstract is also not displayed in the backoffice, should we also add it in the content tab?

In order to display the type of the alternative title I would propose to move it down, as it is done for the identifiers (see image below), WDYT? image

kpsherva commented 2 years ago

Did you verify where the alternative titles were before the latest changes erased them? In the backoffice the type of the subtitle should be also displayed

Yes they were removed in this PR apparently there was an "others" tab. I displayed the information as it is done in the frontsite. Note that the alternative_abstract is also not displayed in the backoffice, should we also add it in the content tab?

In order to display the type of the alternative title I would propose to move it down, as it is done for the identifiers (see image below), WDYT? image

in general I think we should think here what is the best for the librarians UX. We have the choice between having alternative titles next to the title (convenience) and not giving the secondary information (i.e alternative titles) so much meaning to move it up into the prominent place in the metadata display, additionally, the information takes space in the UI. Personally I wouldn't give them a separate section as the identifiers have, for the simple reason that they are not as important. It it not as common to have this information either, so I would leave it next to the title as you did, but displayed as follows:

- alter title (ALTERNATIVE TITLE TYPE)
- ...