search

inveniosoftware / react-invenio-app-ils

Single Page App built with React for InvenioILS.
https://react-invenio-app-ils.readthedocs.io
MIT License
5 stars 19 forks source link

Comment: Hmm I understand that we need to add this here because at the form cmp level these are not loaded as we can add new fields dynamically. #597

Open kpsherva opened 4 months ago

kpsherva commented 4 months ago 
          Comment: Hmm I understand that we need to add this here because at the form cmp level these are not loaded as we can add new fields dynamically.

The only issue I can see is that in terms of performance this is worse as it will loop over items that were already processed. I would rather set the onkeydown when creating it, but in a first look it doesn't seem easy to do with rjsf ... However it's probably kicking in only when working on array fields so it should be good enough IMHO.

_Originally posted by @jrcastro2 in https://github.com/inveniosoftware/react-invenio-app-ils/pull/593#discussion_r1508748169_