search

inveniosoftware / react-invenio-deposit

React application for Invenio deposit forms.
https://react-invenio-deposit.readthedocs.io
MIT License
3 stars 46 forks source link

Missing space between orcid icon and name in deposit form #468

Closed fenekku closed 2 years ago

fenekku commented 2 years ago

Package version (if known): 8.0

Describe the bug

Space missing between orcid icon and name:

orcid_spacing_deposit_page

lhenze commented 2 years ago

According to Orcid brand guidelines, the icon must follow the name. WDYT of this. Other ideas? Screen Shot 2022-03-14 at 5 26 34 PM

lhenze commented 2 years ago

Screen Shot 2022-04-20 at 12 23 44 PM

The previously proposed solution would require refactoring and perhaps be fairly involved. Here's an idea for a short-term solution. https://github.com/inveniosoftware/react-invenio-deposit/compare/master...lhenze:bug/1378-orcid-icon?expand=1

lhenze commented 2 years ago

The missing space issue is now resolved. @fenekku, ok to close this?

Screen Shot 2022-05-31 at 7 20 17 AM
fenekku commented 2 years ago

Yes, I will close this. I made another issue for another ORCID-related ticket: https://github.com/inveniosoftware/react-invenio-deposit/issues/508. Thanks!