search

inveniosoftware / react-invenio-deposit

React application for Invenio deposit forms.
https://react-invenio-deposit.readthedocs.io
MIT License
3 stars 45 forks source link

components: updated custom fields components. #627

Closed alejandromumo closed 1 year ago

alejandromumo commented 1 year ago

closes https://github.com/inveniosoftware/invenio-rdm-records/issues/1232

alejandromumo commented 1 year ago

LGTM! Just a couple of comments. When doing changes in the UI, it would be nice if we add some screenshots of the changes to visualize them easily.

Thanks for the comments!

The screenshots are attached to the issue. I had them in this PR but then it made sense to move them there since the mockups are also there (easier to compare "side by side"

jrcastro2 commented 1 year ago

LGTM! Just a couple of comments. When doing changes in the UI, it would be nice if we add some screenshots of the changes to visualize them easily.

Thanks for the comments!

The screenshots are attached to the issue. I had them in this PR but then it made sense to move them there since the mockups are also there (easier to compare "side by side"

Ah, right! Thanks for the screenshots. I didn't scroll down and missed them, maybe it's worth mentioning in the PRs that the screenshots are available in the issue ;)