inveniosoftware / react-invenio-forms

React component library for Formik components.
https://react-invenio-forms.readthedocs.io
MIT License
0 stars 27 forks source link

Add DiffTimestamps function #240

Closed carlinmack closed 3 months ago

carlinmack commented 3 months ago

:heart: Thank you for your contribution!

Description

Please describe briefly your pull request.

At the moment we have toRelativeTime which produces a string like "in 2 minutes" or "2 minutes ago" from one timestamp.

In this PR I introduce diffTimestamps which produces a string like "2 minutes" from two time stamps.

Unfortunately I have had to write my own version of this as we are using an old version of Luxon. I'm not sure how much hassle it would be to upgrade Luxon.

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
carlinmack commented 3 months ago

moving this code to invenio-jobs