inveniosoftware / react-searchkit

React component library for interacting with a REST API.
https://inveniosoftware.github.io/react-searchkit/
MIT License
78 stars 40 forks source link

change the test adapter to support react 17 #212

Open chelakis opened 2 years ago

chelakis commented 2 years ago

Closes #211

Changed the adapter to work with react 17, changed react, react-dom versions and run the tests again with success

ntarocco commented 2 years ago

Thank you for this PR. We are discussing how to release it, because we cannot force react v17 at the moment in many other projects.

avivace commented 2 years ago

Thank you for this PR. We are discussing how to release it, because we cannot force react v17 at the moment in many other projects.

Great! Keep also in mind that react-overridable would also need to be bumped when there'll be a release supporting React 17. We have a PR there too: https://github.com/indico/react-overridable/pull/14