Update dropdowns for a11y

lhenze commented 2 years ago

Adds "selectOnNavigation=false" to not submit each option as keyboard-only user navigates among them with the down arrow Adds aria-labels for screenreaders

closes https://github.com/inveniosoftware/react-searchkit/issues/220

:heart: Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

:rotating_light: Please review the guidelines for contributing to Invenio.

[ ] Did you create different commits for logically separate things? Check the format of the commit(s) message(s).
[ ] [InvenioRDM specific] Did you follow the style guide? Check the documentation.
[ ] [InvenioRDM specific] Did you add translations (i18n) for new labels, backend and frontend? Check the documentation.
[ ] [InvenioRDM specific] Did you add accessibility (a11y) tags? Check the documentation.
[ ] Did you add documentation? We all love well-documented frameworks, right?
[ ] Did you include third-party code (a library, package, etc.)? If yes:
- [ ] Make sure that its open source license is compatible with Invenio (note: GPL and AGPL licensed code is not accepted)
- [ ] Did you respect the license conditions (normally you need to keep the copyright and license header)?

Green light on all GitHub Actions status checks is required in order to merge your PR. Check your code additions will fail neither code linting checks nor tests and will not decrease test coverage.

External contributors

Copyright

[ ] Identify who is the copyright holder (a legal entity - i.e. person or organization - normally this is your employer) for the produced code.
[ ] Make sure that you have updated the copyright headers for touched files (non-trivial contributions >15 lines).

See copyright and license policy for details.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

If you ticked all the boxes above, you're good to go! :rocket:

lhenze commented 2 years ago

I think adding translations isn't possible yet: depends on https://github.com/inveniosoftware/react-searchkit/issues/223

lhenze commented 2 years ago

Hi, moved to pending review, question is, how essential to provide translations for default props?

ntarocco commented 2 years ago

I think we don't have translations support at the moment in RSK, but we should indeed have! I think that @mb-wali was doing some work to move the i18n core features in some reusable modules, then we could add it here too... Ping @zzacharo

lhenze commented 2 years ago

Hi @ntarocco, thanks, I made the change ... selectOnNavigation is now a property, defaulting to false, for the four components.

inveniosoftware / react-searchkit