inveniosoftware / react-searchkit

React component library for interacting with a REST API.
https://inveniosoftware.github.io/react-searchkit/
MIT License
78 stars 40 forks source link

Analyse 'SearchBarUncontrolled' component. #225

Open alejandromumo opened 2 years ago

alejandromumo commented 2 years ago

This issue is created to analyse whether SearchBar component can be fully uncontrolled. Right now, its state variable currentValue is initialised based on the prop queryString which is controlled by the component's parent (<SearchBarUncontrolled>).

queryString is a prop currently connected by Redux to the store's state state.query.queryString

The current implementation is updating the component's internal state rather than the redux one.

https://github.com/inveniosoftware/react-searchkit/blob/9274d994803f572c36f29a69d32e3548d08db379/src/lib/components/SearchBar/index.js#L17-L20.