Issue with clear facets button

inveniosoftware / react-searchkit

React component library for interacting with a REST API.

https://inveniosoftware.github.io/react-searchkit/

MIT License

78 stars 40 forks source link

Issue with clear facets button #266

Open Ducica opened 3 months ago

Ducica commented 3 months ago

Package version (if known): latest 2.2.5

Clear button in Bucket aggregations is not working.

You can see also in Zenodoo, when one clicks on clear it duplicates this aggregation, instead of eliminating it.

As I see it, the issue is in the implementation of updateQueryFilters selector

ulysseus-eu commented 2 months ago

I think it is linked to this commit: https://github.com/inveniosoftware/react-searchkit/commit/908fd5c493a5f40ea8af5db9a7ed38e940bacb78

Let me know what you think but reverting the commit seems safer than taking more time to find a fix to the corner case. It's affecting all instances with recent JS dependencies, whatever the invenio-rdm version.

zzacharo commented 2 months ago

ping @psaiz