inveniosoftware / react-searchkit

React component library for interacting with a REST API.
https://inveniosoftware.github.io/react-searchkit/
MIT License
78 stars 40 forks source link

Use class methods instead of property methods with arrow functions #90

Closed equadon closed 4 years ago

equadon commented 4 years ago

Currently, it is not possible to subclass and override methods in many of the classes in react-searchkit because some methods are property methods with arrow functions which can't be inherited.

Some examples of classes with these issues:

These methods probably should be converted to normal methods in the class and bind this in the constructor.