search

invent-framework / invent

Express yourself with code.
https://invent-framework.github.io/
Apache License 2.0
108 stars 12 forks source link

Split up core.py #105

Closed mhsmith closed 2 weeks ago

mhsmith commented 2 weeks ago

So far I've moved the Property classes into a module of their own, and completely decoupled them and their tests from Component, and even from PyScript itself.

Unit tests all pass, but I haven't checked the builder yet.

I haven't committed the ZIPs, because I'm not sure what the plan is to deal with them. Shouldn't they be .gitignored? Updating them with every commit will rapidly inflate the size of the repository.

I also haven't updated src/pyscript.toml, because it's already way out of date with the source files list. Does anything use it?

TBD:

ntoll commented 2 weeks ago

Aha..! Nice work @mhsmith - I had splitting up core.py on my todo list for today. Since you have this in flight already, I'll not start that work until we've had a chat in tomorrow's pairing session. :+1:

ntoll commented 2 weeks ago

FWIW, I had in mind to create a new core directory in which would be found the various source files, from which the __init__ would reference the classes/objects we hoped to export via __all__ in the invent.ui.core module. :+1:

But, as always, anything I say or suggest is always open for discussion and feedback. Ideas most welcome.

mhsmith commented 2 weeks ago

I had in mind to create a new core directory in which would be found the various source files, , from which the init would reference the classes/objects

That makes sense, and it reduces the number of other files that need to be updated. I've done that, and also moved Page, Row, Column and Grid into a containers package.

The unit tests all pass, and the builder still works as it did before, as far as I can see.