inventaire / inventaire-client

webapp coupled to the inventaire server :books:
https://inventaire.io
48 stars 16 forks source link

rewrite users_home network/public navs in Svelte #367

Closed maxlath closed 1 year ago

maxlath commented 1 year ago

The big chunk here being the rewrite of the public nav map, for which I experimented with ideas from https://imfeld.dev/writing/svelte_domless_components and https://github.com/ngyewch/svelte-leaflet to be able to use a more Svelte-idiomatic syntax

jum-s commented 1 year ago

I try to display a marker on the public map (/users/public), so there is a user poetically named "aaa", who has a publicly shared "Les misérables" item and a position in Paris. After logging with the user "adamsberg" and going to users/public in paris, then "aaa" is not visible, but it should, right? Precision: aaa and admasberg are not friends and do not belong to any common group What am I missing?

maxlath commented 1 year ago

"aaa" is not visible, but it should, right?

Yes, it should: any user with a position should be visible on the map. Do you see the user doc in the response from

curl 'http://localhost:${DEV_SERVER_PORT}/api/users?action=search-by-position&bbox=[2.1588,48.7608,2.6189,48.9699]' 

? Do you see such a GET /api/users?action=search-by-position request being made by the client when you browse the map over paris?

jum-s commented 1 year ago

"aaa" is not visible, but it should, right?

Yes, it should: any user with a position should be visible on the map. Do you see the user doc in the response from

curl 'http://localhost:${DEV_SERVER_PORT}/api/users?action=search-by-position&bbox=[2.1588,48.7608,2.6189,48.9699]' 

? Do you see such a GET /api/users?action=search-by-position request being made by the client when you browse the map over paris?

works fine

jum-s commented 1 year ago

After navigating the map, users category is not up to date. The bug is more obvious when a lot of markers exists.

Here is the initial state: 2023-02-20_17-28

Here is the bug : Tomohito should appear in the user category, but instead the main user adamsberg is displayed but it should not. FYI it looks like Tomohito never appears again in the user category no matter how much i zoom out 2023-02-20_17-23

Another way to reproduce what looks like the same bug; if i zoom in and zoom out again, a lot less markers are on the map (aka initial state is not recovered) 2023-02-20_17-30

maxlath commented 1 year ago

After navigating the map, users category is not up to date

should have been fixed by 30945cb2e