search

inventaire / inventaire-client

webapp coupled to the inventaire server :books:
https://inventaire.io
49 stars 16 forks source link

Move loading message within selector's dropdown #382

Closed jum-s closed 1 year ago

jum-s commented 1 year ago

Since it can take some time to load facets, and information on what to select can be displayed as soon as advanced option is clicked on.

To do this, we extracted the sync part out of getWorksFacets, and allow selector to have a default value placeholder

A friendly message is displayed within the selector (reviewer: don't be lured by the absence of i18n key, CSS should be correct when key exists)

This is preparing ground for adding large reverse claims values to get filtered (ie. wdt:P69 educated at, or wdt:P166 award received)

jum-s commented 1 year ago

After loading hundreds of times these entities layouts recently, i came to the conclusion that loading relativeEntitiesList often take less time. And i think it would be a better UX to only display those relativeEntitiesList only after worksBrowser is displayed to not have this jump/pushed down. Would you be okay if i add a commit to this PR that does that? [Edit] done in e2c1e4364, but not sure/satisfied with it (see commit message)

maxlath commented 1 year ago

I rebased this branch on master, resolved the conflicts, and force pushed, but I can revert it if that's not welcome