search

inventaire / inventaire-client

webapp coupled to the inventaire server :books:
https://inventaire.io
48 stars 16 forks source link

Hide spinner when 100 results are displayed #397

Closed jum-s closed 10 months ago

jum-s commented 1 year ago

Since its the maximum displayable. This will not give the false impression that more results will be displayed if the user waits.

This is a quick fix based on the fact that the server is not displaying more than 100 results.

maxlath commented 10 months ago 
  limit: { default: 10, max: 100 },
  offset: { default: 0, max: 500 },

so a single request limit is 100, but more batches can be requested: the effective limit is maxOffset+maxLimit = 500 + 100 = 600, no?

jum-s commented 10 months ago

offset: { default: 0, max: 500 },

Offsets are for subjects search only, which does not appear to display more results than the first batch...

but more batches can be requested

Yes, this PR takes for a fact that those requests (beyond 100) do not provide any results (hence keep spinner spinning). This PR only here to not lure users into waiting for results that will never come.

In a better world, we would need some investigation to find out why additional batches are not displayed.

This PR was just a quick fix 6 months ago for a better UI. It could be discarded in favor of the aforementioned investigation. But if not, i would be for a merge.