search

inventaire / inventaire-client

webapp coupled to the inventaire server :books:
https://inventaire.io
48 stars 16 forks source link

fix #448: Display book count in user profile #449

Closed lasconic closed 10 months ago

lasconic commented 10 months ago

Anything I need to do for this PR to be accepted ?

jum-s commented 10 months ago

After some digging, it appears that this book count display on user profile was existing but it has not been re-implemented by the Svelte rewrite, only the template has been rewritten. I think it would be preferable to find out why inventoryLength is not populated anymore. You are welcome to rebase your attempts on this pull request or close this and open a new one. Thanks !

lasconic commented 10 months ago

I think it would be preferable to find out why inventoryLength is not populated anymore.

I believe this PR does just that. It populates inventoryLength in main_user.js

jum-s commented 10 months ago

Yes, it does populate the main user. I was thinking of having a broader solution to display inventoryLength on all other user profiles (as issue title suggest). But it does solve what got raised in the matrix channel. Having a inventoryLength on every user profile can come later, at Svelte rewrite . Thanks!

lasconic commented 10 months ago

For all users, it's more involved indeed since I'm not sure which 'length' we want to display. Private/public books? Books the main user could see ?