search

inventid / tails

Models on the fly!
MIT License
1 stars 0 forks source link

Extending Collectable overrides include method from Mixable #11

Closed steffansluis closed 10 years ago

steffansluis commented 10 years ago

The export of Backbone.Collection methods in Tails.Mixins.Collectable overrides the 'include' method from Tails.Mixable, resulting in faulty behaviour of Mixins included after the extension of Collectable.

steffansluis commented 10 years ago

This is 'fixed' on develop now. The include methode is not longer overridden because it is no longer exported. This is not a great fix since name collisions are the real problem, not just this instance of it. That should however get it's own unrelated issue, so this one can be closed.

joostverdoorn commented 10 years ago

After some thought I think it might be best if we just create the all() accessor to the collection. That way we don't pollute the class namespace too much, which already has proved to be a problem and might do so again in the future.

steffansluis commented 10 years ago

@joostverdoorn We have that already through collection(), so effectively we would just be removing the proxies to collection on the class, which is fine. There should be a better way to proxy stuff anyway, possibly related to #12. I do like the idea of making common methods available to use on the class, but not at the cost of bugs.

rogierslag commented 10 years ago

As an idea, we should probably do the separate work in branches, and use pull requests (with references to the issue) to keep track of we want to accept that specific solution to that issue.

Using the current method we get a bit of workflow issues in the future...

steffansluis commented 10 years ago

@rogierslag @joostverdoorn I agree we should use branches from now on. Lets use the naming convention "feature/name-with-dashes" and rebasing on develop in stead of merging for the feature branches. I think we should also have minor version numbers using git tags on develop, with a minor version bump after every merge from a feature branch to develop and major version number on master with a bump every time develop is merged. Do you agree?

rogierslag commented 10 years ago

Let's continue this discussion in https://github.com/inventid/tails/issues/14 to keep things clear