search

inventid / tails

Models on the fly!
MIT License
1 stars 0 forks source link

Code Coverage comments #19

Closed rogierslag closed 10 years ago

rogierslag commented 10 years ago

@joostverdoorn @steffansluis Do you like the comments from Coveralls.io on pull requests (eg https://github.com/inventid/tails/pull/16#issuecomment-50649637)

I kinda like them, since it makes the coverage very clear. But I can image other don't. Should I disable it?

steffansluis commented 10 years ago

I like it! It emphasizes the importance of testing your code, and it's a nice way to see how merging a PR will affect our test coverage.

steffansluis commented 10 years ago

We haven't heard any complaints yet about the comments, and since there are at least two people who like the feature I think we can close this issue for now. If anyone feels strongly about turning the comments off, it can always be reopened.