inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.32k stars 781 forks source link

Purchase order doesn't find all components - and uses wrong currency #6647

Closed tomse closed 1 week ago

tomse commented 8 months ago

Please verify that this bug has NOT been raised before.

Describe the bug*

So I'm trying out a purchase order and import a .csv - all the components are added beforehand. Some components are shown in step 3 of the import, and some are not - red circles in the screenshots.

(should I make a new bug report for the currency?) My currency default is Danish Kr., but for this supplier I've chosen USD. (see yellow circles) How can I make a selection that everything should be in USD? having 20+ different components is tedious to change.

image

Here you can see one of the individual parts that aren't to find for the same supplier partnumber (column selection naming would be nice if they also are the same as Step 2 in the csv import). image

Steps to Reproduce

Make an order, make sure all the components have been added beforehand. Get a CSV with your order and upload it.

Expected behaviour

all the missing component fields should be filled out.

Deployment Method

Version Information

[0.13.5]

Please verify if you can reproduce this bug on the demo site.

Relevant log output

No response

tomse commented 8 months ago

LCSC_Exported.csv

Attached is my CSV file

SchrodingersGat commented 8 months ago

(should I make a new bug report for the currency?) My currency default is Danish Kr., but for this supplier I've chosen USD. (see yellow circles) How can I make a selection that everything should be in USD? having 20+ different components is tedious to change.

Please raise a new issue for this. The importer for purchase order items does not currently support switching currency AFAIK. So this would need to be implemented

SchrodingersGat commented 8 months ago

Regarding this issue - For line number 4, in the drop-down menu can you find and select the c131154 component?

tomse commented 8 months ago

Regarding this issue - For line number 4, in the drop-down menu can you find and select the c131154 component?

unfortunately no

image

image

SchrodingersGat commented 8 months ago

unfortunately no

That's very weird then. Can you find the supplier part in the global search drop-down (magnifying glass icon in the top right of the screen)?

tomse commented 8 months ago

very weird indeed..

yes, I can also find it in "Parts" search/filter box

here is a partial search for "c13" image

The components have all been added using kintree (don't know if that helps).

I'm really at a loss here.. I've been trying to see any differences between a found component and unfound component.

Running in docker, are there any logs I can look in to supply more data?

SchrodingersGat commented 8 months ago

@tomse I cannot think of any more tests to run for this. It is very strange.

In the "import" window, when you type something (e.g. "C13") into the drop-down menu, can you show the API request and response data? This is available in the "developer" tab in your browser

tomse commented 8 months ago

@SchrodingersGat I hope the following screenshots are what you're requesting

by import window I'm understanding this one? image

image

image

image

image

SchrodingersGat commented 8 months ago

@tomse no that's just for notification fetching. You'll need to capture while you are typing into the box. It should send a search query with the text you type, back to the server

tomse commented 8 months ago

@SchrodingersGat I'm not sure if I'm doing this correctly Using firefox: Step 3 in uploading csv.

Web Developer Tools

"ALL" seems messy - specially under Response where I get a truncated html output with 40k lines image

SchrodingersGat commented 8 months ago
  1. You can filter by XHR
  2. Just before you select the drop-down, clear the log
  3. As you type you should see the requests going to the server
tomse commented 8 months ago

I'm doing something wrong.. sorry.. web dev tools is not something I'm fluent in.. not even 1% I cleared "something" and now the request/response are empty, even after reloading the page. it would probably be best that you describe in better detail what I need to do, I'm ok in switching browser is that is your preference

I do get this filter output in another window, but it doesn't matter if I select request/response, it shows the same

image

wolflu05 commented 8 months ago

What @SchrodingersGat meant was doinging the following with the Select input where you have the issues (this was using chrome, but should work with firefox too):

https://github.com/inventree/InvenTree/assets/76838159/8dfe46e0-9ca3-4e68-8588-7bdcf2f920e0

tomse commented 8 months ago

what am I doing wrong? (make note I expect we are in the step 3 of uploading the csv rather than adding a new part)

https://github.com/inventree/InvenTree/assets/1444539/5059d298-1d32-45bd-9ea5-e3b73ea79f57

SchrodingersGat commented 8 months ago

@tomse that looks correct. What request data is being sent?

It looks like the response is empty. For the response:

tomse commented 8 months ago

I noticed a new webserver and settings in the docker .env file.. is that something to look into?

is this what you're asking for? image

SchrodingersGat commented 8 months ago

@tomse huh, looking into the code it appears that this import method does not make use of the API. The options for each drop-down are pre-rendered on the server...

This is all going to be totally refactored as part of our roadmap to fix the import/export interface. Perhaps you would be willing to contribute funding towards this feature?

tomse commented 8 months ago

@SchrodingersGat done :-)

SchrodingersGat commented 8 months ago

@tomse thanks! In the mean time, you could also use the admin import functionality to get your data into the system? This one edge case is very strange.

github-actions[bot] commented 6 months ago

This issue seems stale. Please react to show this is still important.

tomse commented 6 months ago

strange didn't get a notification other than the bot.. should we keep the issue open ?

SchrodingersGat commented 6 months ago

@tomse I will keep it open as it is referenced by a PR which will address it: https://github.com/inventree/InvenTree/pull/6911

tomse commented 5 months ago

@tomse I will keep it open as it is referenced by a PR which will address it: #6911

Thanks mate :-)

SchrodingersGat commented 1 week ago

This has now been addressed in #6911