inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.34k stars 786 forks source link

[PUI] Updates for AdminButton #8434

Closed SchrodingersGat closed 2 weeks ago

SchrodingersGat commented 2 weeks ago

Tasklist

netlify[bot] commented 2 weeks ago

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit b7a58e856032817becc8610aad132e215fc26c4f
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/672a91e0e190f200085580c6
Deploy Preview https://deploy-preview-8434--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (93a8090) to head (b7a58e8). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rc/frontend/src/components/buttons/AdminButton.tsx 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8434 +/- ## ========================================== + Coverage 84.44% 84.49% +0.04% ========================================== Files 1170 1170 Lines 53460 53463 +3 Branches 2003 2004 +1 ========================================== + Hits 45146 45174 +28 + Misses 7793 7759 -34 - Partials 521 530 +9 ``` | [Flag](https://app.codecov.io/gh/inventree/InvenTree/pull/8434/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | Coverage Ξ” | | |---|---|---| | [backend](https://app.codecov.io/gh/inventree/InvenTree/pull/8434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `85.91% <ΓΈ> (+<0.01%)` | :arrow_up: | | [pui](https://app.codecov.io/gh/inventree/InvenTree/pull/8434/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `68.63% <50.00%> (+0.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matmair commented 2 weeks ago

Great to see the ToDos addressed but I am not sure about the API response change

SchrodingersGat commented 2 weeks ago

@matmair I'll revert the changes to the API endpoint as suggested.