Closed jacobfelknor closed 6 days ago
Name | Link |
---|---|
Latest commit | 46a9b408ce106f81433f1b9246583c4994181c7b |
Latest deploy log | https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6737b88ce62650000829282a |
This should also address: https://github.com/inventree/InvenTree/discussions/8365#discussioncomment-11072737
Force pushed to amend commit author which was incorrect, my apologies
@matmair @wolflu05 are either of you in a position to review this properly? I have no experience with LDAP
I do not have a non-prod setup with LDAPS right now, I would have to build something up in my lab so if Lukas has something I would let him test it.
For reference, these are the new setting values I used to make this work in my environment
INVENTREE_LDAP_GROUP_OBJECT_CLASS: group
INVENTREE_LDAP_GROUP_TYPE_CLASS: NestedMemberDNGroupType
INVENTREE_LDAP_GROUP_TYPE_CLASS_ARGS: member
INVENTREE_LDAP_GROUP_TYPE_CLASS_KWARGS: '{"name_attr": "cn"}'
Sorry, I have currently also no testing setup and very limited time, so this will take me some time to get to it. I'd appreciate if someone of you could test this.
@jacobfelknor can you confirm that the new settings are working for your setup?
Yes, I'm currently using these settings in my instance and it works with my environment
Ok, can you please fix the style issues and I'm happy to merge. If there are any issues which arise you may get tagged :)
Okay, I think that should fix the styling
Attention: Patch coverage is 31.25000%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 84.34%. Comparing base (
fbe222f
) to head (46a9b40
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jacobfelknor thanks for the contribution :)
Addresses https://github.com/inventree/InvenTree/issues/6101
Allow more granular LDAP group configuration. If no action is taken, this behaves as it did before due to defaults.