inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.36k stars 790 forks source link

fix various sonarlint warnings #8479

Closed matmair closed 1 week ago

netlify[bot] commented 1 week ago

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit c081f0ae9c30761273993f60ec90a641131c66ef
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67358b54c0560e00087c85a6
Deploy Preview https://deploy-preview-8479--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (9d8f874) to head (c081f0a). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nd/src/tables/settings/BarcodeScanHistoryTable.tsx 14.28% 6 Missing :warning:
...c/frontend/src/components/plugins/PluginDrawer.tsx 0.00% 4 Missing :warning:
...frontend/src/components/nav/NotificationDrawer.tsx 0.00% 1 Missing :warning:
...end/src/components/plugins/PluginSettingsPanel.tsx 0.00% 1 Missing :warning:
...rontend/src/components/plugins/RemoteComponent.tsx 50.00% 0 Missing and 1 partial :warning:
src/frontend/src/tables/settings/ErrorTable.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8479 +/- ## ========================================== + Coverage 84.31% 84.34% +0.02% ========================================== Files 1178 1178 Lines 53731 53690 -41 Branches 2022 2022 ========================================== - Hits 45305 45284 -21 + Misses 7916 7896 -20 Partials 510 510 ``` | [Flag](https://app.codecov.io/gh/inventree/InvenTree/pull/8479/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | Coverage Δ | | |---|---|---| | [pui](https://app.codecov.io/gh/inventree/InvenTree/pull/8479/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `68.63% <65.85%> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.