[PUI] Fixing sonarcloud issues

SchrodingersGat commented 3 days ago

Testing a different approach to https://github.com/inventree/InvenTree/pull/8478

netlify[bot] commented 3 days ago

Deploy Preview for inventree-web-pui-preview ready!

Name	Link
Latest commit	e6e970cfef412762715795c91553207c340570b9
Latest deploy log	https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673c58d567d3860008eb0957
Deploy Preview	https://deploy-preview-8518--inventree-web-pui-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (no change from production) Accessibility: 86 (no change from production) Best Practices: 100 (no change from production) SEO: 78 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

SchrodingersGat commented 3 days ago

@matmair @wolflu05 what are your thoughts on this approach?

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (e4a3969) to head (e6e970c). Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
src/frontend/src/pages/build/BuildDetail.tsx	0.00%	5 Missing :warning:
...ntend/src/pages/purchasing/PurchaseOrderDetail.tsx	0.00%	4 Missing :warning:
src/frontend/src/pages/sales/ReturnOrderDetail.tsx	0.00%	4 Missing :warning:
src/frontend/src/pages/company/CompanyDetail.tsx	0.00%	2 Missing :warning:
src/frontend/src/pages/sales/SalesOrderDetail.tsx	50.00%	2 Missing :warning:
src/frontend/src/hooks/UseImportSession.tsx	0.00%	1 Missing :warning:
...ntend/src/pages/company/ManufacturerPartDetail.tsx	0.00%	1 Missing :warning:
.../frontend/src/pages/company/SupplierPartDetail.tsx	0.00%	1 Missing :warning:
src/frontend/src/pages/part/CategoryDetail.tsx	0.00%	1 Missing :warning:
src/frontend/src/pages/part/PartDetail.tsx	0.00%	1 Missing :warning:
... and 2 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8518 +/- ## ========================================== + Coverage 84.52% 84.54% +0.01% ========================================== Files 1177 1177 Lines 53565 53591 +26 Branches 2025 2025 ========================================== + Hits 45278 45309 +31 + Misses 7762 7751 -11 - Partials 525 531 +6 ``` | [Flag](https://app.codecov.io/gh/inventree/InvenTree/pull/8518/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | Coverage Δ | | |---|---|---| | [pui](https://app.codecov.io/gh/inventree/InvenTree/pull/8518/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `68.99% <7.69%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: