inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.34k stars 786 forks source link

Relation update #8524

Closed SchrodingersGat closed 2 days ago

SchrodingersGat commented 2 days ago
netlify[bot] commented 2 days ago

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit afb0f2f63f1190bcd4ff847350e5ef59f45f14ef
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673cf9f9e470220009760275
Deploy Preview https://deploy-preview-8524--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (🟒 up 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (2bc6ddb) to head (afb0f2f). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/part/api.py 76.47% 4 Missing :warning:
src/frontend/src/tables/part/RelatedPartTable.tsx 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8524 +/- ## ========================================== + Coverage 84.52% 84.63% +0.10% ========================================== Files 1176 1178 +2 Lines 53555 53580 +25 Branches 2023 2025 +2 ========================================== + Hits 45265 45345 +80 + Misses 7785 7709 -76 - Partials 505 526 +21 ``` | [Flag](https://app.codecov.io/gh/inventree/InvenTree/pull/8524/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | Coverage Ξ” | | |---|---|---| | [backend](https://app.codecov.io/gh/inventree/InvenTree/pull/8524/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `85.96% <83.33%> (+0.01%)` | :arrow_up: | | [pui](https://app.codecov.io/gh/inventree/InvenTree/pull/8524/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `69.36% <33.33%> (+0.57%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

wolflu05 commented 2 days ago

We might could also overengineer this by adding a second table like relation types which can be selected. That way we can keep this field much clear/filter/… by common relations types. E.g. show all additional equipment relations, … But that’s just a thought

matmair commented 2 days ago

Using a state would probably be user-friendly as custom states would make it easy to extend the selection without adding new interfaces that need management functionality and discovery. That could be added as a separate PR to keep this one in the imminent 0.17.0

wolflu05 commented 1 day ago

Using a state would probably be user-friendly as custom states would make it easy to extend the selection without adding new interfaces that need management functionality and discovery. That could be added as a separate PR to keep this one in the imminent 0.17.0

@matmair should we create an issue to track this then? Maybe you could do that with you ideas about the custom states? I'm not so familiar with the new state system.