inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.34k stars 786 forks source link

[PUI] SSO improvments #8527

Open matmair opened 2 days ago

matmair commented 2 days ago

This addresses various ux issues/bugs in the SSO implementation in PUI.

Fixes https://github.com/inventree/InvenTree/issues/7972

netlify[bot] commented 2 days ago

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit 67ad876d354591d0e1929fa0f895ce93f22f0c2d
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673e2dfad8b93700084c1634
Deploy Preview https://deploy-preview-8527--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.61%. Comparing base (13440a6) to head (67ad876). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/backend/InvenTree/InvenTree/social_auth_urls.py 28.00% 18 Missing :warning:
src/frontend/src/components/buttons/SSOButton.tsx 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8527 +/- ## ======================================= Coverage 84.61% 84.61% ======================================= Files 1178 1178 Lines 53584 53590 +6 Branches 2026 2027 +1 ======================================= + Hits 45340 45346 +6 + Misses 7722 7717 -5 - Partials 522 527 +5 ``` | [Flag](https://app.codecov.io/gh/inventree/InvenTree/pull/8527/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/inventree/InvenTree/pull/8527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `85.95% <35.71%> (-0.01%)` | :arrow_down: | | [pui](https://app.codecov.io/gh/inventree/InvenTree/pull/8527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `69.31% <0.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

matmair commented 1 day ago

@SchrodingersGat @wolflu05 this now works but is not very beautiful; is this changeset ok or should we (I) search for a different solution?

SchrodingersGat commented 1 day ago

@matmair can you please provide a simple overview of what the issue was that you are fixing here? I understand the frontend fix (hiding the buttons if invalid) but what about the backend changes?