inventree / InvenTree

Open Source Inventory Management System
https://docs.inventree.org
MIT License
4.34k stars 786 forks source link

Better handling for undefined values in SettingsList #8531

Closed SchrodingersGat closed 2 days ago

netlify[bot] commented 2 days ago

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit 995e30a498ea66a459ee5793726d6ff5cdedc2ee
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673da3b6fd700600080fc335
Deploy Preview https://deploy-preview-8531--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.56%. Comparing base (41a9b68) to head (995e30a). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/frontend/src/components/settings/SettingList.tsx 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8531 +/- ## ========================================== - Coverage 84.66% 84.56% -0.10% ========================================== Files 1178 1178 Lines 53584 53584 Branches 2026 2026 ========================================== - Hits 45366 45314 -52 - Misses 7696 7745 +49 - Partials 522 525 +3 ``` | [Flag](https://app.codecov.io/gh/inventree/InvenTree/pull/8531/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | Coverage Δ | | |---|---|---| | [pui](https://app.codecov.io/gh/inventree/InvenTree/pull/8531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree) | `69.00% <0.00%> (-0.54%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inventree#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: