search

inventree / inventree-brother-plugin

Label printing plugin for Brother series printers
MIT License
16 stars 12 forks source link

Fix label size #21

Closed evmosseveld closed 1 year ago

SchrodingersGat commented 1 year ago

@evmosseveld what tape sizes have you tested this on?

evmosseveld commented 1 year ago

@evmosseveld what tape sizes have you tested this on?

Currently I only have the 29mm x 90mm die-cut tape to test it with, so I don't know if it works for all labels. The problem I was having was that the label wouldn't print because the brother_ql library only accepts the image if it's precisely the correct size (at least for my media type, but I suspect it's the same for all die-cut tapes). So I needed to resize the image (as stated in the code ideally there would be a GUI in InvenTree to configure sizing options just as you have printing options in desktop applications for example). Also, I don't know if this would be the right place to fix this or if it would be better to fix this in the brother_ql library so that it accepts all image sizes and resizes the image itself.

evmosseveld commented 1 year ago

Btw I was wondering which things were meant by these 2 TODOs:

# TODO: Add padding around the provided image, otherwise the label does not print correctly
# TODO: Improve label auto-scaling based on provided width and height information

The resizing I have now implemented, is that what was meant by 'padding' in the TODO? The same goes for the auto-scaling (although the 'provided width and height' that we get are those of the label template before conversion to PDF and PNG so I don't know how useful that information would be).

SchrodingersGat commented 1 year ago

Do you have some images of this working with the printer please? :) I don't have a printer available for testing right now

evmosseveld commented 1 year ago

Do you have some images of this working with the printer please? :) I don't have a printer available for testing right now

Yeah here you go :) This is a printed label for a stock item. If you need any more pictures or testing I will go to the office again next week. Currently I only have the 29x90 die cut labels to test it with unfortunately, but I think the resizing will work fine for other sizes as well. 20230607_154352 20230607_154433 20230607_154545

SchrodingersGat commented 1 year ago

@evmosseveld thanks for the improvements, I'll push a new release