search

inventree / inventree-brother-plugin

Label printing plugin for Brother series printers
MIT License
16 stars 12 forks source link

[FR] I think we need a config for rotation #6

Closed simonkuehling closed 2 years ago

simonkuehling commented 2 years ago

@SchrodingersGat, using a QL-720NW label printer with 62mm endless tape, I realize that we would probably need to make image rotation a config option in the plugin settings... Do you agree?

This looks a little excessive as it is *g

22-04-13 13-58-53 3584

SchrodingersGat commented 2 years ago

Yeah, for sure it should be an option. Feel free to submit a PR, the addition of the new option would be very simple if you just follow the existing code!

simonkuehling commented 2 years ago

happy to do so :+1:

matmair commented 2 years ago

This was closed with #6 @simonkuehling could you close it?

simonkuehling commented 2 years ago

Sure - closing this.

matmair commented 2 years ago

@simonkuehling thx and thank you for the PR. We are not very used to users also submitting what they wont programmed from us ;-)

simonkuehling commented 2 years ago

Its a real pleasure to see a project documented and structured as well as this - so that it is even possible to start contributing as fast in the first place… well done!

matmair commented 2 years ago

@simonkuehling glad to hear that! If you want to change anything or have an idea for additional features do not hesitate to ping @SchrodingersGat (maintainer) or me. We are always happy to engage!

SchrodingersGat commented 2 years ago

Thanks again for the contribution too, @simonkuehling - I'm glad that you were able to get it working :)