search

inventree / inventree-python

Python library for communication with inventree via API
https://docs.inventree.org/en/latest/api/python/python/
MIT License
26 stars 34 forks source link

Fix unit tests #113

Closed toastedcrumpets closed 2 years ago

toastedcrumpets commented 2 years ago

I was working on a 'stock/transfer' endpoint implementation in this library, and I keep running into a strange error where the inventree API reports a field is required, even when its provided.

I tried checking your unit tests to see if you're picking up similar errors, but I notice they're silently failing: https://github.com/inventree/inventree-python/runs/6958148020?check_suite_focus=true

Should your CI report these checks failing?

matmair commented 2 years ago

Hi there @toastedcrumpets and thank you for your report! I am not really part of this part of the ecosystem but to me it seems like the assertions are met. Maybe @eeintech or @SchrodingersGat can make light of the situation.

A transfer function sounds exciting. Eager to see what you come up with. If you want feedback there is always the option to create a draft PR.

toastedcrumpets commented 2 years ago

Ah, my mistake, they are intentional fails but they're being logged to output as well as handled. Thanks for the reply!

matmair commented 2 years ago

No worries, I am also a bit worried each time I see them 8n the logs. But turning them off makes degbuging hard.

Thanks for creating the issue anyhow @toastedcrumpets , contributions outside of core devs are really encouraging as they show ppl care enough to engage.