Add sales order shipment

[miggland]

Just to let you know I'm working on adding the basic Shipment functionality to the python binding. This is a contribution to #90.

Basic functions include:

• listing shipments for an order
• adding a shipment against an order

This should allow retrieving the allocated items as well.

[SchrodingersGat]

@miggland looks like this has stalled somewhat.. Any further work happening on this one soon?

[miggland]

I had some trouble with the syntax of creating shipments, and a lack of time. I'm just as not as productive as you guys ;) However, it's not completely stalled, just going slow..

[SchrodingersGat]

@miggland looks like there is a pretty critical bug in the current python implementation which is preventing your attempts here to work (as per your discussion in https://github.com/inventree/InvenTree/discussions/3256).

Basically, for the POST method we use data=... rather than json=... - this causes the data sent to the server to be encoded as a string rather than a JSON object. This appears to be OK for flat requests but nested ones fail!

Looking into this now

[SchrodingersGat]

@miggland once https://github.com/inventree/inventree-python/pull/123 is merged, pull master back in to your branch and you should then be able to get it working

[SchrodingersGat]

@miggland #123 is merged in now so you should be able to proceed with this. LMK if you need any assistance.

[matmair]

@miggland ther are still some style issues but looks great otherwise!

[miggland]

Thanks @matmair . The tests are quite working yet either.. I'll get there though! :D

[miggland]

This should allow retrieving the allocated items as well.

This part is covered by 'allocations' field in Shipment item.

[matmair]

@miggland that is normal for working with a new code base. You are down to 1 error so it is looking good. If you require assistance feel free to ping inventree/maintainer inventree/triage

[miggland]

Finally - I'm going to let you review this now, see if you agree with the approach taken.

There are two ways to allocate Items - the simplest way is via the SalesOrderLineItem.allocateToShipment() method, which should be supplied with at least a Shipment object. Further options include limiting which stock items to choose from.

The alternative, which requires defining the items-dict, is to the use the SalesOrderShipment.allocateItems()

[SchrodingersGat]

@miggland looks like a really solid implementation :)

Only request is to add some unit testing for the SalesOrderLineItem.allocateToShipment method - currently this is not being tested.

[SchrodingersGat]

@miggland LMK if you can add this small extra unit test 👍

[miggland]

I will

[miggland]

I broke another test oops

[SchrodingersGat]

I broke another test oops

Not sure what you did, though.. That test does not seem related to your code at all!

[miggland]

Could one of those stock items have been depleted, and automatically deleted, because I assigned and shipped them?

[SchrodingersGat]

Ah, good call! That is probably what is happening :) Probably best to change the test to >= 19 as we cannot guarantee what order the tests run in.

[miggland]

If you say that's OK, sounds like a simple fix :)

Funnily, this test didn't fail on my test machine.

[SchrodingersGat]

Thanks for the fixes, and for your continued contributions :)

[matmair]

@miggland nice landing! FYI: I am not even running the tests on my machine anymore. Just code, run through the thing you changed and let GitHub do its thing - that way you can work on something else meanwhile 😇