search

inventree / inventree-python

Python library for communication with inventree via API
https://docs.inventree.org/en/latest/api/python/python/
MIT License
26 stars 34 forks source link

Add Metadata #189

Closed miggland closed 1 year ago

miggland commented 1 year ago

See https://github.com/inventree/inventree-python/issues/188

SchrodingersGat commented 1 year ago

@miggland so this just adds in the existing metadatamixin to more models?

miggland commented 1 year ago

Yes - if there were some way to detect if metadata is active for a certain URL, that would be cleaner. However, this solution is pretty simple - just needs to be kept up to date.

miggland commented 1 year ago

Yes - if there were some way to detect if metadata is active for a certain URL, that would be cleaner. However, this solution is pretty simple - just needs to be kept up to date.

SchrodingersGat commented 1 year ago

@miggland probably the best approach - I don't think there's an easy way to introspect this

matmair commented 1 year ago

@miggland would this close #188?

miggland commented 1 year ago

Yes, I think I caught them all

On 13 May 2023 22:09:15 CEST, Matthias Mair @.***> wrote:

@miggland would this close #188?

-- Reply to this email directly or view it on GitHub: https://github.com/inventree/inventree-python/pull/189#issuecomment-1546741849 You are receiving this because you were mentioned.

Message ID: @.***>

SchrodingersGat commented 1 year ago

@miggland ready for merge then?

miggland commented 1 year ago

From my side yes

On 14 May 2023 11:18:31 CEST, Oliver @.***> wrote:

@miggland ready for merge then?

-- Reply to this email directly or view it on GitHub: https://github.com/inventree/inventree-python/pull/189#issuecomment-1546852775 You are receiving this because you were mentioned.

Message ID: @.***>

SchrodingersGat commented 1 year ago

Thanks for the contribution ☺️