search

inventree / inventree-wireviz

Plugin for integrating wireviz into InvenTree
MIT License
7 stars 0 forks source link

Add graphviz as dependency so pip could install it automatically #37

Open Petrox opened 11 months ago

Petrox commented 11 months ago

This would solve the docker container customization with every new release overhead for any users here.

automatic apt-getting in the container env is decided to be not implemented https://github.com/inventree/InvenTree/issues/5718

SchrodingersGat commented 11 months ago

Can this be installed via pip?

Petrox commented 11 months ago 
pip3 install graphviz
Collecting graphviz
  Using cached https://files.pythonhosted.org/packages/9d/fb/886e8ec7862989afc0c35d15813b6c665fe134cc6027cdde2fa300abe9a2/graphviz-0.19.1-py3-none-any.whl
Installing collected packages: graphviz
Successfully installed graphviz-0.19.1
SchrodingersGat commented 11 months ago

Right, but the python graphviz package is already installed as part of wireviz

Is this not getting installed automatically?

Petrox commented 11 months ago

TBH I didn't check if it installs it or not, I've read the readme some time ago that it depends on graphviz and I should install it.

WireWiz requires GraphViz to be installed in order to work. See the GraphViz download page for OS-specific instructions.

Maybe it is not necessary at all if graphviz (python package) is installed?

When I was using the stable container I got the error, that it could not find the graphviz binary, so it either not included in the pip package or not in PATH inside the container.

SchrodingersGat commented 11 months ago

To be clear, the graphviz python package gets installed automatically, as part of this plugin, but you need to have the graphviz binary also installed on your system - I don't think PIP takes care of this part