invernizzi / scapy-http

Support for HTTP in Scapy
Other
301 stars 77 forks source link

Status of Scapy HTTP #46

Open gpotter2 opened 5 years ago

gpotter2 commented 5 years ago

@invernizzi

Hi,

Now that HTTP has been pushed back to the main Scapy repo (with quite a bunch of improvements/features/fixes for Python 3): https://github.com/secdev/scapy/pull/1925 (or will be, if you're reading this before 2.4.3 :smile:), the question stands of what this project should do/become.

It is pretty clear that the project development has stopped:

Collaborator wanted! Hi there, internet stranger! As time is a scarce resource for me nowadays, I'm looking for a collaborator to handle issues and pull requests in a more timely manner. If you are interested, send me an email at invernizzi.l@gmail.com.

(I wrote an email back in May but didn't get an answer).

The issue is that installing scapy_http will now break Scapy's implementation (http layer), rather than doing any good.

One option we have would be to deprecate it, and clearly raise a warning/error while installing. If this can't be done (no answer from the owners), the other option is that we (on Scapy) raise an error when it is installed.

I hope to get any feedback :smile:

invernizzi commented 5 years ago

Hi Gabriel, I'm glad to hear that Scapy now supports HTTP! I fully agree with you, let's add a warning on installation. If you're up to it, I'll leave it to you on how to do it best. I've added you as collaborator to the repo.

invernizzi commented 5 years ago

Looking closer, it seems that your PR hasn't been merged yet. Let's wait until that happens.

gpotter2 commented 5 years ago

Thanks for the reply ! (Sorry, I didn't expect you to answer that quickly :smile:) The PR has been merged. It will be included in Wednesday's RC 3.

Would you agree making a release with the deprecation when we release 2.4.3 ? (This won't happen before mid-August. We need to finish the RCs first)

invernizzi commented 5 years ago

On Mon, Jul 8, 2019, 07:27 Gabriel notifications@github.com wrote:

Thanks for the reply ! (Sorry, I didn't expect you to answer that quickly 😄) The PR has been merged. It will be included in Wednesday's RC 3.

Would you agree making a release with the deprecation when we release 2.4.3 ? (This won't happen before mid-August. We need to finish the RCs first)

Sure. Makes sense

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/invernizzi/scapy-http/issues/46?email_source=notifications&email_token=AABCM7NOWL4KELZYJ3ZDYKDP6NFERA5CNFSM4H4ZOK5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNIERQ#issuecomment-509248070, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCM7M6TBGXHARFGM5N7ELP6NFERANCNFSM4H4ZOK5A .