invernyx / smartcars-3-bugs

The bug tracker for the smartCARS 3 application
3 stars 0 forks source link

[BUG] - Engine logs are inaccurate in XP11 #187

Closed walkerairtrans closed 1 year ago

walkerairtrans commented 1 year ago

Describe the bug

I'm opening this up on behalf of my VA and another who posted in Discord.

I've started getting reports from my testers that in XP11 they are seeing situations where single engine planes say all 4 engines started, or a twin engine says that engines 3/4 started, or in weird case spawning in engines 3/4 are on, but then 1/2 show up in the log when starting the real engines.

It seems to only happen in smartCARS 3. They've tested the same aircrafts (at my request) in smartCARS 2 and these behaviors do not happen.

See screenshots I've collected below.

How do you reproduce this bug?

  1. I'm not sure how to really replicate this but to simply load with planes and start a flight to review the behavior.

Expected behavior

It should show the right engines.

Screenshots

Image from the Discord thread. image

Images from my team. image

image

This one my pilot loaded in cold and dark. He then started engines 1/2 like normal. image

Operating system

Windows 11

Community airline

Walker Air Transport

smartCARS Version

0.9.0

Plugins installed

chat, map, flight center, flight tracker, logbook

Additional context

No response

turbofandude commented 1 year ago

@walkerairtrans Can you try edit the engine part of your config as follows and see if it still causes the issue?


{
      "condition": "{engine1Firing} not_equals false",
      "message": "Engine 1 On"
    },
    {
      "condition": "{engine1Firing} equals false",
      "message": "Engine 1 Off",
      "initialValue": true
    },
    {
      "condition": "{engine2Firing} not_equals false and {enginesCount} > 1",
      "message": "Engine 2 On"
    },
    {
      "condition": "{engine2Firing} equals false and {enginesCount} > 1",
      "message": "Engine 2 Off",
      "initialValue": true
    },
    {
      "condition": "{engine3Firing} not_equals false and {enginesCount} > 2",
      "message": "Engine 3 On"
    },
    {
      "condition": "{engine3Firing} equals false and {enginesCount} > 2",
      "message": "Engine 3 Off",
      "initialValue": true
    },
    {
      "condition": "{engine4Firing} not_equals false and {enginesCount} > 3",
      "message": "Engine 4 On"
    },
    {
      "condition": "{engine4Firing} equals false and {enginesCount} > 3",
      "message": "Engine 4 Off",
      "initialValue": true
    }
turbofandude commented 1 year ago

@walkerairtrans Scratch the above, I made a mistake - let's try this one:

{
      "condition": "{engine1Firing} not_equals false",
      "message": "Engine 1 On"
    },
    {
      "condition": "{engine1Firing} equals false",
      "message": "Engine 1 Off",
      "initialValue": true
    },
    {
      "condition": "{engine2Firing} not_equals false and {enginesCount} greater_than 1",
      "message": "Engine 2 On"
    },
    {
      "condition": "{engine2Firing} equals false and {enginesCount} greater_than 1",
      "message": "Engine 2 Off",
      "initialValue": true
    },
    {
      "condition": "{engine3Firing} not_equals false and {enginesCount} greater_than 2",
      "message": "Engine 3 On"
    },
    {
      "condition": "{engine3Firing} equals false and {enginesCount} greater_than 2",
      "message": "Engine 3 Off",
      "initialValue": true
    },
    {
      "condition": "{engine4Firing} not_equals false and {enginesCount} greater_than 3",
      "message": "Engine 4 On"
    },
    {
      "condition": "{engine4Firing} equals false and {enginesCount} greater_than 3",
      "message": "Engine 4 Off",
      "initialValue": true
    },
walkerairtrans commented 1 year ago

Roger that. I’ll be home from vacation tomorrow and will give it a try.

walkerairtrans commented 1 year ago

@walkerairtrans Scratch the above, I made a mistake - let's try this one:

{
      "condition": "{engine1Firing} not_equals false",
      "message": "Engine 1 On"
    },
    {
      "condition": "{engine1Firing} equals false",
      "message": "Engine 1 Off",
      "initialValue": true
    },
    {
      "condition": "{engine2Firing} not_equals false and {enginesCount} greater_than 1",
      "message": "Engine 2 On"
    },
    {
      "condition": "{engine2Firing} equals false and {enginesCount} greater_than 1",
      "message": "Engine 2 Off",
      "initialValue": true
    },
    {
      "condition": "{engine3Firing} not_equals false and {enginesCount} greater_than 2",
      "message": "Engine 3 On"
    },
    {
      "condition": "{engine3Firing} equals false and {enginesCount} greater_than 2",
      "message": "Engine 3 Off",
      "initialValue": true
    },
    {
      "condition": "{engine4Firing} not_equals false and {enginesCount} greater_than 3",
      "message": "Engine 4 On"
    },
    {
      "condition": "{engine4Firing} equals false and {enginesCount} greater_than 3",
      "message": "Engine 4 Off",
      "initialValue": true
    },

Looks like this worked!