search

invernyx / smartcars-3-bugs

The bug tracker for the smartCARS 3 application
3 stars 0 forks source link

[FEATURE] - Implement `SC3` User agent for VA requests #341

Closed jordanhavard closed 9 months ago

jordanhavard commented 9 months ago

Is your feature request related to a problem? Please describe.

A recent bug caused a huge spike in traffic from the SC3 to VA servers. The user agent was axios/1.3.5 without any real context.

Describe the solution you'd like

To help VA administrators filter out potentialy DDoS attacks, please include something like SC3 in the user agent, so this can be monitored

Describe alternatives you've considered

n/a

Additional context

Screenshot for reference image

Discord link for reference https://discord.com/channels/589851727373795331/589858287004942356/1156422082838667275

SC2 user agent for reference image

EDIT: It appears the login is sending the user agent but not the tracking plugin CleanShot 2023-09-27 at 16 47 26

GenericNerd commented 9 months ago

As much as I understand the intention behind this change, there are a couple of things I want to point out:

  1. I do not believe this type of issue will occur any time soon. We are aware of the problems that caused this to happen, both in code and through our review processes and we are working on changes internally to ensure that these types of issues never occur again.
  2. While all the TFDi Design plugins could do this if another plugin does not, it completely goes against the point of adding it to our plugins in the first place. I do not see this contributing to the overall experience of the program for community administrators or for users of smartCARS