invernyx / smartcars-3-phpvms5-api

The API responsible for connecting smartCARS to phpVMS 5
MIT License
7 stars 7 forks source link

[BUG] - phpvms 7 - PIREPS being submitted as manual #82

Closed dlpilotz closed 1 year ago

dlpilotz commented 1 year ago

Describe the bug

smartcars 3 pireps are being submitted as manual pireps in the phpvms 7 system, this causes the auto processing of pireps to break.

How do you reproduce this bug?

  1. Log a flight with SC3
  2. Submit
  3. View phpvms 7 admin center and youll have a pending "manual (smarcars 3)" PIREP.

Expected behavior

Should have its own class of submitting instead of manual to allow for processing.

Screenshots

image

API Version

0.3.4

PHP Version

8.0.11

Database & version

10.5.12 MariaDB

Webserver version

Apache

Browser

Chrome

Handler

phpvms7

Additional context

No response

GenericNerd commented 1 year ago

Do you happen to know what the database fields should be to submit the PIREP as a ACARS PIREP?

I've tried reaching out to nabeel to try to see what changes we need to make to our API to make it more "phpvms7-esc", but I've not had a reply and we're navigating blind on a still in-development system

jordanhavard commented 1 year ago

Do you happen to know what the database fields should be to submit the PIREP as a ACARS PIREP?

I've tried reaching out to nabeel to try to see what changes we need to make to our API to make it more "phpvms7-esc", but I've not had a reply and we're navigating blind on a still in-development system

Have linked PR #83 which has the fix for you

GenericNerd commented 1 year ago

I’ve just noticed that I’ve already resolved this in the phpVMS 7 branch. When the update releases, this will be resolved!