search

inverse-inc / packetfence-monitoring-scripts

PacketFence Monitoring Scripts
2 stars 5 forks source link

check-tmp.sh doesn't detect huge numbers of dirs or files #30

Open nqb opened 6 years ago

nqb commented 6 years ago

On a setup, I got many files created in /tmp with following layout:

# tree adcli-krb5-YfnplZ/
adcli-krb5-YfnplZ/
└── krb5.d
    └── adcli-krb5-conf-8YbXQa

check-tmp.sh didn't detect that issue due to maxdepth and type options.

I think we could remove -maxdepth 1 option in: https://github.com/inverse-inc/packetfence-monitoring-scripts/blob/a358f696b826bd92fd85a5028d79d3c925ad39e9/scripts/check-tmp.sh#L6

because we will always search for many files in /tmp. But I'm sure this option has not been put here by chance.

What's your opinion on this ?

julsemaan commented 6 years ago

I believe we did put maxdepth since the issue we were looking to fix involved the PF temp files (created by the perl lib we use) and they are put in /tmp/ directly.

We would have to see if it could be normal to have more than the default $MAX_TMP_FILES if we remove maxdepth and adjust it accordingly

nqb commented 6 years ago

@julsemaan: could you refer the issue you mentioned ?

julsemaan commented 6 years ago

This comes from a time where we weren't tracking everything via Github issues

You could see point 1 of the following section in the private wiki: https://wiki.inverse.ca/focus/PacketFence/StabilityOfOurDeployments#Ideas_for_better_stability