search

inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.31k stars 278 forks source link

email template: unexpected behavior with default sponsor source #3664

Open nqb opened 5 years ago

nqb commented 5 years ago

When you use the default sponsor source (with no mandatory fields other than the guest's email), emails sent to sponsor will be unclear due to missing firstname/lastname fields: screenshot from 2018-10-09 15-36-39

In this situation, template should use guest's email address at beginning of the sentence.

mendoza-conicet commented 5 years ago

It also presents problems with the "Activate Access" button. it does not write the activation_uri variable, which makes it impossible to use this feature. It seems to me that I should have a higher priority.

nqb commented 5 years ago

@mendoza-conicet: 8.3 version ? Apply maintenance patches and retry..

mendoza-conicet commented 5 years ago

@nqb i'm using 8.3, after apply maintenance patches work well!

jrouzierinverse commented 4 years ago

This seems to be fixed can we close?

nqb commented 3 years ago

Reopening, issue still presents.

jrouzierinverse commented 2 years ago

@nqb should #7069 close this one also?

nqb commented 2 years ago

@jrouzierinverse, I look quickly but it seems that this issue is caused by the fact that html/captive-portal/templates/emails/emails-guest_sponsor_activation.html use firstname and lastname before the word "requested".

Because these fields are empty (as you can see on the screenshot), there is nothing to display.

IMHO, if we use a tag like firstname and lastname in an email template, we need to be sure these fields are mandatory in the form where we asked them. So I don't think #7069 solve this use case.