search

inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.37k stars 287 forks source link

default SMS source: sms_carriers option #3877

Open nqb opened 5 years ago

nqb commented 5 years ago

sms_carriers option should include all the SMS carriers in DB.

It looks like the latest additions in DB haven't been added in conf/authentication.conf

julsemaan commented 5 years ago

Yeah this is because we reference the SMS carriers in authentication.conf as well.

We have 2 choices:

  1. We adjust authentication.conf.example
  2. We support making the sms_carriers empty and when its the case, it displays all the carriers in the DB

Would be cleaner to do option 2 and it would be future-proof

nqb commented 5 years ago

In option 2, admin can select SMS carriers in a dropdown list in the auth source.

However, if they don't, the default sms source will not work: guest can't select a provider which has not been defined in the source.

julsemaan commented 5 years ago

This is why we need to change the backend code to magically fill in all the carriers when the list is empty

extrafu commented 5 years ago

@nqb Please add manually the ones that are missing and open a PR.

nqb commented 5 years ago

For 8.3, I fixed missing sms_carriers in 7a1af6c