inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.37k stars 287 forks source link

I18N: handle Portal Modules strings in extract_i18n_strings.pl #3913

Open nqb opened 5 years ago

nqb commented 5 years ago

Following strings are currently added by hand in PO file:

msgid "default_actions"
msgstr "Execute module default actions"

msgid "set_unregdate"
msgstr "Set unregistration date"

msgid "no_action"
msgstr "Don't do any action"

msgid "unregdate_from_source"
msgstr "Set unregistration date from the auth source"

msgid "role_from_source"
msgstr "Set role from the auth source"

msgid "time_balance_from_source"
msgstr "Set the time balance from the auth source"

msgid "bandwidth_balance_from_source"
msgstr "Set the bandwidth balance from the auth source"

msgid "actions"
msgstr "Actions"

msgid "multi_source_ids"
msgstr "Sources"

They could be found here (not actions and multi_source_ids):

But these two files are part of the captive-portal, not the webadmin. In webadmin, these strings are dynamically generated/localized, see (https://github.com/inverse-inc/packetfence/blob/devel/html/pfappserver/lib/pfappserver/Form/Config/PortalModule.pm#L113)

nqb commented 5 years ago

What is the best way to handle these specific strings ?