inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.

https://packetfence.org

GNU General Public License v2.0

1.32k stars 279 forks source link

v9-gui: "Configuration > Advanced access configuration" issues (keep it open until the list is empty) #4160

Closed dondon21 closed 5 years ago

dondon21 commented 5 years ago

[x] it's possible to add text in the IP field of the captive portal tab
[x] the reset button don't delete the text in the IP field on the captive portal tab
[x] HTTP code 500 on the new billing tier tab
[x] The error is not clear when a wrong path is set on the PKI provider path
[ ] The locality list is empty in the SCEP PKI option in the PKI provider tab
[x] Cannot add OS in the provisioner tab
[x] Cannot reset conf of the portals modules
[x] Cannot add new portals modules
[x] Cannot reset configuration on new device registration tab
[x] Cannot add OS in the new device registration tab
[ ] Cannot delete the previous device registration created in the alt GUI in the old GUI

Filter Engines

[x] Tab names are different from old GUI and new GUI and not in the same order

satkunas commented 5 years ago

@jrouzierinverse the following are due to missing meta:

The locality list is empty in the SCEP PKI option in the PKI provider tab
Cannot add OS in the provisioner tab
Cannot add OS in the new device registration tab

satkunas commented 5 years ago

The error is not clear when a wrong path is set on the PKI provider path

Moved to #4224

Cannot delete the previous device registration created in the alt GUI in the old GUI

May be related, or not... Moved to #4225

satkunas commented 5 years ago

@cgx these are yours:

Cannot reset conf of the portals modules
Cannot add new portals modules

This looks similar to cache poisoning to/from the store. See https://github.com/inverse-inc/packetfence/pull/4220/commits/cdee0b79a5b90d3f3e151ba137622eb9378518dc for my fix using JSON to dereference in/out.

jrouzierinverse commented 5 years ago

The issue 'Cannot delete the previous device registration created in the alt GUI in the old GUI' May not be an issue. If a device registration is defined in a profile then it cannot be deleted. This need better error handling.

satkunas commented 5 years ago

Tab names are different from old GUI and new GUI and not in the same order

Filters are dynamic and sorted in the backend. The best I can do is alphabetize them.

satkunas commented 5 years ago

Remainder moved to #4257