Configuration/inline random data allowed in the fields

inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.

https://packetfence.org

GNU General Public License v2.0

1.27k stars 274 forks source link

Configuration/inline random data allowed in the fields #4307

Open dondon21 opened 5 years ago

dondon21 commented 5 years ago

It's possible to fill the form with random data in the inline tab : Related to :

Accounting session timeout
Accounting sync interval
Ports redirect
SNAT Interface

Such as letters, numbers, special chars or whatever.

julsemaan commented 5 years ago

This has always been the case actually, we would need to adjust the form to perform this validation

Since its not an issue specific to 9.0, I'd suggest we push this to "+1 patch release" and address it later

satkunas commented 5 years ago

Added numeric checks for

Accounting session timeout
Accounting sync interval

in https://github.com/inverse-inc/packetfence/commit/127e2f9990fdb9a2f63a041a1083b1cc74b1e6d8

The other two will need to be changed to controlled array inputs before validation can be added.