search

inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.32k stars 279 forks source link

Unregister a node doesn't work anymore #5816

Closed nqb closed 4 years ago

nqb commented 4 years ago

Describe the bug According to integration tests, if you try to unregister a node using an API call, it doesn't work anymore.

I guess it's related to merge of recent PR like #5724.

nqb commented 4 years ago

Error in packetfence.log :

Sep 22 07:17:51 pfdeb9dev packetfence: pfperl-api(3182) DEBUG: Calling API with ReAssign request on switch 44:38:39:00:00:12) (pf::enforcement::_vlan_reevaluation)
Sep 22 07:17:51 pfdeb9dev packetfence: pfperl-api(3182) ERROR: call not implemented                                                             (Mojolicious::Plugin::DefaultHelpers::_development)                                                                                                                                                            
Sep 22 07:17:51 pfdeb9dev packetfence: pfperl-api(3182) DEBUG: 500 Internal Server Error (0.118429s, 8.444/s) (Mojolicious::Controller::rendered)
fdurand commented 4 years ago

Sep 25 10:32:46 localhost pfqueue: pfqueue(28924) INFO: [mac:c8:60:00:50:cf:0b] Instantiate profile default (pf::Connection::ProfileFactory::_from_profile) Sep 25 10:32:49 localhost packetfence: pfperl-api(28594) INFO: re-evaluating access (admin_modify called) (pf::enforcement::reevaluate_access) Sep 25 10:32:49 localhost packetfence: pfperl-api(28594) INFO: Instantiate profile default (pf::Connection::ProfileFactory::_from_profile) Sep 25 10:32:49 localhost packetfence: pfperl-api(28594) INFO: VLAN reassignment is forced. (pf::enforcement::_should_we_reassign_vlan) Sep 25 10:32:49 localhost packetfence: pfperl-api(28594) INFO: switch port is (172.20.21.84) ifIndex 2connection type: Wired MAC Auth (pf::enforcement::_vlan_reevaluation) Sep 25 10:32:49 localhost packetfence: pfperl-api(28594) ERROR: call not implemented (Mojolicious::Plugin::DefaultHelpers::_development)

jrouzierinverse commented 4 years ago

Please retest

nqb commented 4 years ago

Still an issue. I got exact same logs as mentioned in my previous comment.

jrouzierinverse commented 4 years ago

Please retest should be fixed in b3bc399e5d1e40ab3f5a8c00f297e27ad0a21fb2.

nqb commented 4 years ago

I ran an integration tests job on pipeline triggered by this commit. If test failed with following error, it means issue is not fixed.

Edit: I ran again a test because it failed due to #5872

nqb commented 4 years ago

Pipeline passed, should be fix.