inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.29k stars 274 forks source link

Captive portal asks for username/password when Authorization source is used #6972

Open nqb opened 2 years ago

nqb commented 2 years ago

Describe the bug If you configure an Authorization source on a connection profile and you use captive portal with this connection profile, captive portal will ask for username/password which doesn't make sense. Authorization sources should work as Null sources on captive portal or should be ignored.

To Reproduce Steps to reproduce the behavior:

  1. Create an Authorization with a catchall rule
  2. Assign this source to default connection profile
  3. Preview default connection profile

=> You will got a prompt for username/password

Expected behavior Make Authorization sources work as Null source or ignore these sources.

jrouzierinverse commented 1 year ago

Should authorization sources be allowed to be used on the portal? @fdurand any thoughts?

extrafu commented 1 year ago

@nqb Please document for now the workaround.

julsemaan commented 1 year ago

@jrouzierinverse, please investigate this for 12.1

satkunas commented 1 year ago

Ignore and/or tell the user that this auth source can't be used.

satkunas commented 12 months ago

Bypass auth source for this case