search

inverse-inc / packetfence

PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.
https://packetfence.org
GNU General Public License v2.0
1.39k stars 291 forks source link

PF 14.0 and 14.1 upgrade script runs upgrades before stopping services - while downloading "packetfence-upgrade" #8389

Open E-ThanG opened 1 week ago

E-ThanG commented 1 week ago

Describe the bug PF 14.0 and 14.1 is installing all pending packetfence* upgrades immediately after the $ADDS/upgrade/do-upgrade.sh command is executed. It's installing them at the point where only packetfence-upgrade is intended to be installed.

After the upgrades complete it stops services and asks if you also want to upgrade the OS and what version of PF you want to upgrade to. But it's already installed the latest upgrade in the current release train at this point.

To Reproduce Steps to reproduce the behavior:

  1. On a PF 14.0 or 14.1 server use the upgrade script $ADDS/upgrade/do-upgrade.sh or just issue the command apt install packetfence-upgrade
  2. All pending PacketFence upgrades are installed.

Workaround

  1. Use apt-mark hold to hold the pending upgrades except packetfence-upgrade prior to starting the upgrade script.
  2. apt-mark hold packetfence-archive-keyring packetfence-config packetfence-golang-daemon packetfence-ntlm-wrapper packetfence-perl packetfence-pfcmd-suid packetfence-redis-cache packetfence-upgrade packetfence
  3. $ADDS/upgrade/do-upgrade.sh
  4. When packetfence-upgrade is installed and the script beings stopping services, suspend execution (CTRL-Z)
  5. Unhold the upgrades, apt-mark unhold packetfence-archive-keyring packetfence-config packetfence-golang-daemon packetfence-ntlm-wrapper packetfence-perl packetfence-pfcmd-suid packetfence-redis-cache packetfence-upgrade packetfence
  6. Use fg to resume execution.

Expected behavior Fix the underlying issue with the Debian 12 OS or APT scripts that is resulting in this behavior.