fix typo (`LazyServiceIdentifer` -> `LazyServiceIdentifier`)

[unadlib]

Description

changes interface LazyServiceIdentifer name to LazyServiceIdentifier

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

• [x] Updated docs / Refactor code / Added a tests case (non-breaking change)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [x] My change requires a change to the documentation.
• [x] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.
• [x] I have updated the changelog.

[PodaruDragos]

This look fine to me, we need to consider if this might break for users.

[unadlib]

This look fine to me, we need to consider if this might break for users.

Maybe we can keep the original typo interface for now, also provide the interface with the correct name.

[Jameskmonger]

@unadlib I agree, I would propose we keep the renaming (and use the new name internally also) but also export it under an alias of the old name

[PodaruDragos]

We could also release a breaking version, which will include other breaking changes that might come, I'm ok either way. I'll let you guys decide.

[unadlib]

@unadlib I agree, I would propose we keep the renaming (and use the new name internally also) but also export it under an alias of the old name

OK. I have updated it. Please help review.

[codecov-commenter]

Codecov Report

Merging #1483 (d11fa7e) into master (01e5798) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   99.61%   99.56%   -0.06%     
==========================================
  Files          53       53              
  Lines        1566     1364     -202     
  Branches      205      196       -9     
==========================================
- Hits         1560     1358     -202     
  Partials        6        6              

Impacted Files	Coverage Δ
src/constants/error_msgs.ts	100.00% <ø> (ø)
src/annotation/lazy_service_identifier.ts	100.00% <100.00%> (ø)
src/inversify.ts	100.00% <100.00%> (ø)
src/planning/reflection_utils.ts	100.00% <100.00%> (ø)
src/container/container.ts	98.85% <0.00%> (-0.22%)	:arrow_down:
src/planning/plan.ts	100.00% <0.00%> (ø)
src/planning/target.ts	100.00% <0.00%> (ø)
src/bindings/binding.ts	100.00% <0.00%> (ø)
src/container/lookup.ts	100.00% <0.00%> (ø)
src/planning/context.ts	100.00% <0.00%> (ø)
... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[unadlib]

hi, @Jameskmonger Can this MR be merged?

[Jameskmonger]

Thank you for the contribution @unadlib, and apologies for the delay in getting this merged.