inversify / InversifyJS

A powerful and lightweight inversion of control container for JavaScript & Node.js apps powered by TypeScript.

http://inversify.io/

MIT License

11.34k stars 719 forks source link

Travis tests are failing due to latest update to tslint #602

Closed dcavanagh closed 7 years ago

dcavanagh commented 7 years ago

tslint changed how it enforces the no-shadowed-variable

Expected Behavior

Should pass the travis-ci tests

Current Behavior

Failing Travis tests

Possible Solution

Refactor some code to remove shadowed variables Mostly occurs in test files

Steps to Reproduce (for bugs)

https://travis-ci.org/inversify/InversifyJS/builds/251113743

Context

Your Environment

Version used:
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop or mobile):
Link to your project:

Stack trace

remojansen commented 7 years ago

I have merged your PR :tada: thanks a lot for the fix 😄