invertase / dart_custom_lint

💡 Easily write powerful Dart & Flutter lint rules for your projects or for users of your packages.
https://pub.dev/packages/custom_lint
Apache License 2.0
288 stars 65 forks source link

Ignore hidden projects #272

Closed Rexios80 closed 1 month ago

Rexios80 commented 2 months ago

Fixes https://github.com/invertase/dart_custom_lint/issues/271

vercel[bot] commented 2 months ago

@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

docs-page[bot] commented 2 months ago

To view this pull requests documentation preview, visit the following URL:

docs.custom-lint.dev/~272

Documentation is deployed and generated using docs.page.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

Rexios80 commented 2 months ago

Do we still need a test for this? Is there an existing test I can modify?

rrousselGit commented 2 months ago

We always need tests :)

You can modify the one that was added in the previous attempt at fixing this issue: https://github.com/invertase/dart_custom_lint/commit/773b7ef69b0ddae77cbfc803364fdbe8bf4c6846

Rexios80 commented 2 months ago

@rrousselGit I updated the test and double checked that it fails without the fix

Rexios80 commented 2 months ago

@rrousselGit can we get this merged?

rrousselGit commented 2 months ago

I'll fix the CI tomorrow. We'll then see if this PR doesn't cause any regression

CPRmichel commented 1 month ago

any updates on this matter?

rrousselGit commented 1 month ago

Dang it, forgot. master's CI is fixed. But it appears that this PR causes some tests to fail

Rexios80 commented 1 month ago

@rrousselGit The test that's failing is checking if an exception is thrown when package_config.json is missing. The purpose of this PR is to not crash when that is the case. Should we remove that test?

rrousselGit commented 1 month ago

Hum, I think we can remove it yes. It should be tested separately by your test update.

I wonder what that workspace_test.dart failure is about though.

Rexios80 commented 1 month ago

Maybe it used to expect a project to be found that is missing the package file?

rrousselGit commented 1 month ago

It looks like analysis_options.yaml on their own are no-longer detected.

The test name is a bit misleading as it has nothing to do with pubspecs afaik.

Rexios80 commented 1 month ago

@rrousselGit The tests should pass now

rrousselGit commented 1 month ago

Thanks!