Closed Rexios80 closed 1 month ago
@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel.
A member of the Team first needs to authorize it.
To view this pull requests documentation preview, visit the following URL:
Documentation is deployed and generated using docs.page.
Do we still need a test for this? Is there an existing test I can modify?
We always need tests :)
You can modify the one that was added in the previous attempt at fixing this issue: https://github.com/invertase/dart_custom_lint/commit/773b7ef69b0ddae77cbfc803364fdbe8bf4c6846
@rrousselGit I updated the test and double checked that it fails without the fix
@rrousselGit can we get this merged?
I'll fix the CI tomorrow. We'll then see if this PR doesn't cause any regression
any updates on this matter?
Dang it, forgot. master's CI is fixed. But it appears that this PR causes some tests to fail
@rrousselGit The test that's failing is checking if an exception is thrown when package_config.json
is missing. The purpose of this PR is to not crash when that is the case. Should we remove that test?
Hum, I think we can remove it yes. It should be tested separately by your test update.
I wonder what that workspace_test.dart
failure is about though.
Maybe it used to expect a project to be found that is missing the package file?
It looks like analysis_options.yaml
on their own are no-longer detected.
The test name is a bit misleading as it has nothing to do with pubspecs afaik.
@rrousselGit The tests should pass now
Thanks!
Fixes https://github.com/invertase/dart_custom_lint/issues/271