Fix pushing / unshifting falsey elements into Queue

invertase / denque

The fastest javascript implementation of a double-ended queue. Used by the official Redis, MongoDB, MariaDB & MySQL libraries for Node.js and many other libraries.

https://docs.page/invertase/denque

Apache License 2.0

353 stars 33 forks source link

Fix pushing / unshifting falsey elements into Queue #3

Closed jhermsmeier closed 8 years ago

jhermsmeier commented 8 years ago

Attempting to push 0, null or '' would not actually alter the Queue, as they all evaluate to false in non-strict comparison

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling ac68799e7d290863c26082ad15646dc14d35a017 on jhermsmeier:fix-push into 82fdf947bae13a8e4ec7bcc608a52bdb022474ce on Salakar:master.

Salakar commented 8 years ago

Woops, cheers for this again, will publish a new version tomorrow

jhermsmeier commented 8 years ago

Cool, thanks!

Salakar commented 8 years ago

Published to npm 👍