search

invertase / denque

The fastest javascript implementation of a double-ended queue. Used by the official Redis, MongoDB, MariaDB & MySQL libraries for Node.js and many other libraries.
https://docs.page/invertase/denque
Apache License 2.0
353 stars 33 forks source link

Invalid TypeScript definition for .size() #37

Closed paya-cz closed 3 years ago

paya-cz commented 3 years ago

The .size() is defined as:

https://github.com/invertase/denque/blob/b6738e6e5db4a2d335eb44a1403b586db041e0c2/index.d.ts#L36

Shouldn't it return a number?

https://github.com/invertase/denque/blob/b6738e6e5db4a2d335eb44a1403b586db041e0c2/index.js#L94-L98

Salakar commented 3 years ago

Indeed it should! Will get this fixed

Ehesp commented 3 years ago

Fixed https://github.com/invertase/denque/commit/88c89a0957a817c3b3aefd50a90b119d656db3da